Skip to content

Refactory the indicator API on WebImage, using the same design pattern like SwiftUI, return some View #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2019
Merged

Refactory the indicator API on WebImage, using the same design pattern like SwiftUI, return some View #31

merged 4 commits into from
Oct 27, 2019

Conversation

dreampiggy
Copy link
Collaborator

This allows the following syntax:

WebImage(url: url)
.indicator { _, progress in
    ProgressBar(value: progress)
}

Instead of dummy syntax previously

WebImage(url: url)
.indicator ( 
    Indicator { _, progress in
        ProgressBar(value: progress)
    }
)

@dreampiggy dreampiggy added the enhancement New feature or request label Oct 27, 2019
@dreampiggy dreampiggy changed the title Add one convenient method on WebImage to associated indicator with view builder block Refactory the indicator API on WebImage, using the same design pattern like SwiftUI, return some View Oct 27, 2019
@dreampiggy dreampiggy merged commit b62cf93 into master Oct 27, 2019
@dreampiggy dreampiggy deleted the feature_convenient_indicator_API branch October 27, 2019 11:53
@mjswen0923 mjswen0923 mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dreampiggy